Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Be Done #6

Open
ashish2199 opened this issue Nov 15, 2017 · 18 comments
Open

To Be Done #6

ashish2199 opened this issue Nov 15, 2017 · 18 comments

Comments

@ashish2199
Copy link
Owner

ashish2199 commented Nov 15, 2017

I have uploaded initial code for the repository.
I am using Netbeans 8.2 with JDK 1.8.
I hope you would be able to figure out how to import this project to your choice IDE and run it.

I have implemented a animation for walking in the downward direction.

Here are some things which we need to do for now

  • Try to figure out if there could be a better for making animations. The approach I have used now feels length, we need a approach that is more concise and elegant.
  • Implement remaining animations for player to walking in left , right and up direction.
  • Registering keyboard inputs and using it them to make the character walk across the screen using arrow keys for now.
  • Dividing the sprite sheet into individual images so that we don't have to deal with cropping. What do you guys thinks ? A single big sprite sheet or set of images.

Some other tasks which are always helpful to the project.

  • Adding comments to code wherever necessary
  • Refactoring and formatting of the code.
  • Contributing to ReadMe and Wiki of this repository.

What we need to achieve is walking of player across the game screen.

If you have any queries/suggestions then comment down below

Sorry guys, I wont be able to give much time on weekday for this project because of my job.
If any experienced folks see something you can contribute to or provide your opinion on then please do.

@llllllxu
Copy link

Does anyone use eclipse? There are lots of errors when I try to import it.

@lyx13710
Copy link

lyx13710 commented Nov 16, 2017 via email

@ashish2199
Copy link
Owner Author

Okay, I will try to use as a maven project.

@dostertag
Copy link
Contributor

Just a note. I'm using netbeans as well and had errors when I initially fetched the repo. I had to manually select the 1.8 jdk which corrected all errors.

@ashish2199
Copy link
Owner Author

@llllllxu
It maybe that you are using a older JDK or eclipse version.

We will be using JavaFX 8 which is a part of JDK 8.

I cloned the project and opened in it Eclipse Oxygen and didn't get any errors.
Screenshot

Did anyone else get error on opening the project ?

@lyx13710
Copy link

@ashish2199 I got no serious error in Intellij. Can run the program fine without any modification. Btw, shouldn't we open a new issue for this one?

@CiaranRoft
Copy link

Got it up and running in Netbeans, no major problems!

@ashish2199
Copy link
Owner Author

@lyx13710 Yeah we should. It will help others who face similar issues.

@HarrisJT
Copy link
Contributor

I suggest Google style which can be found on github and imported into editors to autoformat.

@lyx13710
Copy link

I found a stackoverflow Q&A which I think is great to implement animation. I'm posting the link here in case you guys are interested. Maybe I'll try to implement it tomorrow.
https://gamedev.stackexchange.com/questions/53705/how-can-i-make-a-sprite-sheet-based-animation-system

@llllllxu
Copy link

Thank you guys. It works now.

@dostertag
Copy link
Contributor

Bear with me, guys. I'm very new to Java and am really glad Ashish created this project. That said, I'm having difficulty wrapping my head around the Entity class and how the other player/ai/stationary objects will inherit from that interface. Any chance some of you have experience creating an UML to explain?
From my (limited) understanding, I see the Entity interface as having:
a position(x, y)
boolean moveable
health
image/sprite

Player would implement Entity and add
void move(event e)???
animate(Direction direction)
attack(dropBomb?)

I realize this is basic and incomplete... I'm willing to learn how to create an UML with easyUML1(netbeans plugin) if no one knows how to but will need a more fleshed-out direction to start.

It seems to me that we'll need to have a basic 'player' implementation before we can set the movement and direction efficiently.

Again, I'm a beginner, and am happy that this was posted in the first place.

@ItsStolas
Copy link
Contributor

Proposed a change the animation system, let me know what you guys think. :)

@lyx13710
Copy link

lyx13710 commented Nov 17, 2017

@CoreyHendrey Having a separate sprite model and animator class might be a good idea. I was already planning to do that last night.

@ashish2199
Copy link
Owner Author

@lyx13710 I didn't understand as to what exactly you refer to by that.
If you wanted to ask my view on changes proposed by Corey, I feel he has done a lot of things. I am at present analyzing them as to whether the approach taken is good or not in the long run.

@StewartWallace1115
Copy link
Contributor

What class should I put character movement? In the Direction class?

@ItsStolas
Copy link
Contributor

Depends. If Ashish accepts my PR it’ll probably be in CharacterEntity.

@ashish2199
Copy link
Owner Author

ashish2199 commented Nov 21, 2017

@StewartWallace1115 what do you refer by character movement ? key events handling or movement of player that is the animation that player will use to walk. I didnt understand.
If anyone else understood please clarify.

Now we don't have character entity. The event handling code will go into Eventhandler class in the game controller package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants