Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] Add replicateSubscriptionsEnabled for namespace and topic #29

Open
wants to merge 1 commit into
base: branch-as-2.10
Choose a base branch
from

Conversation

nodece
Copy link
Collaborator

@nodece nodece commented Dec 10, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@nodece nodece force-pushed the replicateSubscriptionsEnabled branch 2 times, most recently from 84f3b86 to b1b237c Compare December 18, 2024 09:16
@nodece nodece changed the title feat: add replicateSubscriptionsEnabled for namespace and topic [feat][broker] Add replicateSubscriptionsEnabled for namespace and topic Dec 18, 2024
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from b1b237c to 43411ba Compare December 19, 2024 04:00
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from 43411ba to c80c0cb Compare December 19, 2024 07:00
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from c80c0cb to 8bacdb3 Compare December 19, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant