Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SensioFrameworkExtraBundle is not maintained anymore #30

Open
akalineskou opened this issue Dec 22, 2022 · 2 comments
Open

SensioFrameworkExtraBundle is not maintained anymore #30

akalineskou opened this issue Dec 22, 2022 · 2 comments

Comments

@akalineskou
Copy link
Contributor

https://symfony.com/blog/new-in-symfony-6-2-built-in-cache-security-template-and-doctrine-attributes

https://github.com/sensiolabs/SensioFrameworkExtraBundle

How can this library be migrated to the new attributes?

@denisvmedia
Copy link
Member

Good question. I need to study the problem. I will check and get back here.

P. S. It'd be great if someone could have volunteered a pr, as I'm currently not an active user of php.

@akalineskou
Copy link
Contributor Author

akalineskou commented Dec 23, 2022

I just removed the classes from my fork and the composer require (havent removed the tests or updated the readme) https://github.com/artprima/query-filter-bundle/compare/master...akalineskou:query-filter-bundle:master?expand=1

All my tests passed so everything still works the same (was not using them though in my case)

I would also remove them from this one, tag it as a new major version, and if someone was using the old annotation and query config they can be added in a new PR as new functionality

My guess would be that the ConfigConverter can be replaced with a custom value resolver https://symfony.com/doc/current/controller/value_resolver.html#adding-a-custom-value-resolver
Not sure about the QueryFilter annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants