Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify CLI fetch tool logic and main app logic #243

Open
mcantelon opened this issue Nov 7, 2023 · 3 comments
Open

Unify CLI fetch tool logic and main app logic #243

mcantelon opened this issue Nov 7, 2023 · 3 comments
Labels
cleanup Work that can make code/data cleaner or easier to maintain

Comments

@mcantelon
Copy link
Member

mcantelon commented Nov 7, 2023 •
edited
Loading

The CLI fetch tool logic is replicates the main app's fetch logic to a large degree so we should unify the code with module(s) in the main app.

This code should have decent test coverage.
@mcantelon mcantelon added the cleanup Work that can make code/data cleaner or easier to maintain label Nov 7, 2023
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
3bc4fea 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
8a6e9a0 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
ca1c8b6 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
6703ddd 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
9ad6aa0 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
163d41f 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
5182fc3 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 13, 2023
@mcantelon
Code cleanup/refactoring (#243)
3ce55cc 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
1bbae95 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
f60c7b2 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
1b50a1f 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
fcc59dc 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
564dd0e 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
9d62ec5 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
3451b74 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 14, 2023
@mcantelon
Code cleanup/refactoring (#243)
ae84c09 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
de3c39c 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
d3ebf60 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
38e71fa 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
b0e4fdf 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
cfacfcf 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
fed75a2 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
a8b6293 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
59e7af8 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243)
10d9287 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
mcantelon added a commit that referenced this issue Dec 15, 2023
@mcantelon
Code cleanup/refactoring (#243) (#263)
0fbb4ac 
* Replaced use of api_url dict with StorageService instance or ID
* Did some refactoring to unify the AIP fetching code between the main
  app logic and the CLI tool
@mcantelon
Copy link
Member Author

Merged some work to improve this (but there's still some work to be done).

mcantelon added a commit that referenced this issue Mar 19, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
37e338f 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 19, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
36b7244 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
acffed8 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
018dadf 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
f71b0e7 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
3418126 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
5d0d8c8 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
a3882f4 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
d175bd3 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
761af4a 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
b511541 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
94cf53a 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
c9c653c 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
678cc10 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
bc2a86f 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
d1411d1 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Mar 20, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
a5553d8 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
@mcantelon
Copy link
Member Author

A PR for the remaining work has been created: #299

mcantelon added a commit that referenced this issue Mar 22, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
6aa75eb 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue Apr 12, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
8cafebf 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue May 1, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
b71baad 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue May 1, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
a7a2343 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue May 1, 2024
@mcantelon
Refactor fetch CLI tool logic (#243)
a9dc39d 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
mcantelon added a commit that referenced this issue May 2, 2024
@mcantelon
Refactor fetch CLI tool logic (#243) (#299)
efdc60b 
Refactor fetch CLI tool, sharing more functionality with the fetch
Celery task.
@mcantelon
Copy link
Member Author

Merged PR. @sevein had a good idea, though. He could have the CLI fetch tool make a REST API request to trigger fetching rather than having independent logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Work that can make code/data cleaner or easier to maintain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcantelon