Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up lnt view channel #14

Open
Tracked by #10
arshbot opened this issue Jan 14, 2020 · 3 comments
Open
Tracked by #10

speed up lnt view channel #14

arshbot opened this issue Jan 14, 2020 · 3 comments
Labels

Comments

@arshbot
Copy link
Owner

arshbot commented Jan 14, 2020

The command lnt view channel is horrendously slow, especially for a prod node with hundreds of channels. Speed this up to something reasonable

@arshbot arshbot added the v1.0.0 label Jan 14, 2020
@arshbot arshbot mentioned this issue Jan 14, 2020
11 tasks
@arshbot
Copy link
Owner Author

arshbot commented Jan 15, 2020

Did a test against our prod node of how long each portion of this command takes. Here are the results

Channel: 1.50462007522583                                                                                                                                     
Forwards: 0.4369542598724365                                                                                                                                  
Chores: 248.7793128490448
Printing 0.020577192306518555
Final: 250.7416591644287

Clearly the issues is in chores.

@arshbot
Copy link
Owner Author

arshbot commented Jan 15, 2020

Disabling 1ml in chores leads to the following result

Channel: 1.4831092357635498                                                                                                                                   
Forwards: 0.5506646633148193                                                                                                                                  
Chores: 45.36083388328552 
Printing 0.0033931732177734375
Final: 47.398186445236206

I know I implemented asyncio here and only got a 20% boost - perhaps what @tdickman mentioned is the way to go - i.e. caching. I'm not a huge fan, but this wait is inexcusable for what I assume is merely an alias.

Unfortunately I forgot to push on my other laptop ( I know ), so I might leave this one open until I'm near my other laptop again. Considering implementing the caching tooling before then, but there are tons of other low hanging fruit available for me

@arshbot
Copy link
Owner Author

arshbot commented Jan 28, 2020

Added asyncio in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant