Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time improvement #126

Open
bartoszmajsak opened this issue Sep 5, 2017 · 2 comments · Fixed by #203
Open

Build time improvement #126

bartoszmajsak opened this issue Sep 5, 2017 · 2 comments · Fixed by #203

Comments

@bartoszmajsak
Copy link
Member

As we are adding more and more functional tests our build is taking quite a bit of time which will make it harder to have fast feedback loops (either locally or on the CI server). It bumped from ~4:30min to above 7 on my local machine:

[INFO] Reactor Summary:                                                                                                                       
[INFO]                                                                                                                                        
[INFO] Smart testing ...................................... SUCCESS [  0.727 s]                                                               
[INFO] smart-testing-core ................................. SUCCESS [ 13.491 s]                                                               
[INFO] junit-test-result-parser ........................... SUCCESS [  1.728 s]                                                               
[INFO] smart-testing-surefire-provider .................... SUCCESS [  7.337 s]                                                               
[INFO] smart-testing-strategy-changed ..................... SUCCESS [  4.464 s]                                                               
[INFO] smart-testing-strategy-affected .................... SUCCESS [  9.435 s]                                                               
[INFO] smart-testing-strategy-failed ...................... SUCCESS [  2.511 s]                                                               
[INFO] smart-testing-maven-lifecycle-extension ............ SUCCESS [  4.022 s]                                                               
[INFO] smart-testing-test-bed ............................. SUCCESS [07:17 min]                                                               
[INFO] ------------------------------------------------------------------------                                                               
[INFO] BUILD SUCCESS               
[INFO] ------------------------------------------------------------------------                                                               
[INFO] Total time: 07:49 min (Wall Clock)                              
[INFO] Finished at: 2017-09-05T22:17:52+02:00                          
[INFO] Final Memory: 40M/1385M     
[INFO] ------------------------------------------------------------------------ 

We should review our Test Bed tests in order to:

  • minimize redundant/overlapping tests
  • identify those which we could test in isolation (unit tests)
  • narrow the builds for only relevant modules, e.g. .build("config/impl-base") where necessary
@lordofthejars
Copy link
Member

I think .build("config/impl-base") could be applied in several tests.

@bartoszmajsak bartoszmajsak modified the milestone: 0.0.2 Sep 14, 2017
@lordofthejars lordofthejars self-assigned this Oct 2, 2017
lordofthejars added a commit to lordofthejars/smart-testing that referenced this issue Oct 2, 2017
lordofthejars added a commit that referenced this issue Oct 4, 2017
* fix(#126): Improves build time by ignoring overlapping tests and narrow builds

* fix: Deletes overlapping test
@MatousJobanek
Copy link
Contributor

I'm reopening as there is another (not merged) PR related to this issue: #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment