Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to redirect back to upstream if error occurs during oauth flow #4

Open
cdepillabout opened this issue Jul 3, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@cdepillabout
Copy link
Member

Currently in goat-guardian, if an error occurs turning the Twitter OAuth login flow, the end-user is shown a bare-bones error page.

It would be great to have an option to redirect the user to the upstream site, so that the upstream site could display an error.

For instance, if the user is going through the Twitter OAuth login flow, after logging in at Twitter, they will be redirected back to goat-guardian with a login token from Twitter.

Goat guardian needs to check for this login token. If it doesn't exist, an error needs to be shown to the user. Currently, Goat Guardian is just showing a very simple HTTP 500 error page, but this could be improved.

Ideally, Goat Guardian would redirect the user back to the upstream site and let the upstream site display the error.

@cdepillabout cdepillabout added this to the after MVP milestone Jul 3, 2018
@cdepillabout
Copy link
Member Author

I'm adding this as "after MVP", but it could be important enough to add to the MVP.

@cdepillabout
Copy link
Member Author

This is currently only an issue for the Twitter OAuth login flow, but it will probably also be a problem when #1 is implemented for the other OAuth providers.

@cdepillabout cdepillabout added enhancement New feature or request help wanted Extra attention is needed labels Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant