Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with clicking on Links #45

Open
dmastag opened this issue Sep 21, 2020 · 3 comments
Open

Issue with clicking on Links #45

dmastag opened this issue Sep 21, 2020 · 3 comments
Labels
bug workaround okay, its a bug, but a workaround exists

Comments

@dmastag
Copy link

dmastag commented Sep 21, 2020

Am not sure if this is a revealjs problem or a markdeck problem.

If I try to press on a hyper link even using _blank it opens in the same tab.

image

@dmastag
Copy link
Author

dmastag commented Sep 21, 2020

Found that the problem is here
https://github.com/arnehilmann/markdeck/blob/master/docs/showcase/index.html#L768

The generated index.html will have
previewLinks: 'false',

which should actually be
previewLinks: false,

@arnehilmann
Copy link
Owner

interesting, I will have a look into this...

@dmastag
Copy link
Author

dmastag commented Sep 22, 2020

As a user you can fix this by stating it directly in your settings using
previewLinks: false

for example
image

@arnehilmann arnehilmann added the workaround okay, its a bug, but a workaround exists label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug workaround okay, its a bug, but a workaround exists
Projects
None yet
Development

No branches or pull requests

2 participants