Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of CryptographicSponge for Merlin #136

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Jan 29, 2024

Using Merlin, we have the possibility of having a sponge that is not generic on a field.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner January 29, 2024 14:00
@autquis autquis requested review from z-tech, Pratyush and mmagician and removed request for a team January 29, 2024 14:00
Cargo.toml Outdated Show resolved Hide resolved
src/sponge/merlin/mod.rs Outdated Show resolved Hide resolved
src/sponge/merlin/mod.rs Outdated Show resolved Hide resolved
src/sponge/merlin/mod.rs Outdated Show resolved Hide resolved
@autquis autquis requested a review from mmagician February 13, 2024 23:08
@mmagician
Copy link
Member

@hdevalence

@autquis
Copy link
Contributor Author

autquis commented Mar 11, 2024

I had to remove the redundant imports since cargo +nightly check complained. Specifically, Vec is in the prelude and is redundant to import.

@mmagician
Copy link
Member

mmagician commented Mar 11, 2024

@autquis ah yes see also this PR: arkworks-rs/algebra#790 to tackle the same sort of issues in algebra

Edit: I actually wonder why this works, given that similar changes in poly commit failed no-std

@autquis
Copy link
Contributor Author

autquis commented Mar 12, 2024

@mmagician I didn't understand what I should fix in arkworks-rs/algebra#790? As it is merged already.

Why it works: I guess because it is not completely no-default-features and r1cs is enabled. This is the command for no_std check:

cargo build --no-default-features --features=r1cs --target aarch64-unknown-none

@mmagician
Copy link
Member

What I meant is that the algebra PR addressed similar issues.

@autquis autquis requested a review from mmagician April 16, 2024 15:43
@autquis
Copy link
Contributor Author

autquis commented May 1, 2024

A gentle ping :)

@mmagician
Copy link
Member

Also @mmaker since I'm tagging you in a few places now, maybe you could also take a peek at this?

@autquis
Copy link
Contributor Author

autquis commented Jun 28, 2024

CI failure is due to this change probably rust-lang/rust#121752
@Cesar199999 @Antonio95

@Cesar199999
Copy link
Contributor

@autquis Yes sorry, I had to update the branch, I'll fix it

@mmaker
Copy link
Member

mmaker commented Jun 28, 2024

Took a quick peek! The PR looks okay, but there isn't much to say. I'd personally encourage your to add a few lines of documentation so that people are well-aware of the limitations of this trait, especially concerning the statement serialization (the user is on their own) and the bit vs bytes part.

That said, I'm happy to see that people are starting to need something that works both over bytes and algebraic sponges :)

@Pratyush Pratyush enabled auto-merge October 17, 2024 14:10
@Pratyush Pratyush added this pull request to the merge queue Oct 17, 2024
Merged via the queue into arkworks-rs:main with commit bd97ccc Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants