Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Prop Redundancy #311

Open
aristotlepenguin opened this issue Mar 4, 2023 · 0 comments
Open

Item Prop Redundancy #311

aristotlepenguin opened this issue Mar 4, 2023 · 0 comments

Comments

@aristotlepenguin
Copy link
Owner

There are some circumstances where items use descriptions pulled from a prop when there's no reason to do so. If an item's props are comprised of defaults, we ought to leave the prop blank and pull it from the item's definition map. It's a large scale fix and probably should be done after the first item prop related issue on here, the consistency one. However, it will greatly reduce bot startup time and general performance because we won't pull nearly as many items as we did before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant