Updated

This is not being rendered properly in the doc:

I know we provide the default everywhere, e.g., "Defaults to None" but it's not necessary since we have a Default column in our documentation.

Also, since this field is required with SNMPv3, we should update the docstring with something like "SNMPv3 authentication settings. Required when version = v3"

Hi, Carl, I agree with your point. Since we already have a default column, I've removed the string 'Defaults to None.'

As for the content rendering in the document, I've made several attempts to modify it, but it’s still not rendering as expected. Therefore, for the time being, I’ve removed the informative strings from the description to avoid confusion. Please share your thoughts/suggestion on this approach.

Thanks
Geetanjali

You could simplify this logic by looping over read, write, notify. Something like:

for view_type in ["read", "write", "notify"]:
    expected_view = getattr(group, f"{view_type}_view")
    if expected_view and not all([
        (act_view := group_details.get(f"{view_type}View")) == expected_view,
        (view_configured := group_details.get(f"{view_type}ViewConfig"))
    ]):
        self.result.is_failure(
            f"{group} {view_type.title()} View: {expected_view} - "
            f"View configuration mismatch - {view_type.title()} View: {act_view}, "
            f"Configured: {view_configured}"
        )

Also, since group_details.get() could return an empty string, we should handle it in the failure message to avoid having something empty. You should also add a unit test for an output with it:

{
    "groups": {
        "ARISTA_SNMPV3_RO_GROUP": {
            "versions": {
                "v3": {
                    "secModel": "v3Priv",
                    "readView": "ARISTA_FULL_SNMP_TREE_VIEW",
                    "readViewConfig": true,
                    "writeView": "",  # Empty string
                    "notifyView": ""
                }
            }
        }
    }
}

Yeah!..Thanks a lot for the suggestion, @carl-baillargeon! I've updated the test case with the new logic and added unit tests for the empty string check.

show other versions in example - especially with the security model for v3

Please don't use semi columns

I would rather make two error messages, 1 to indicate the view name is not correct (matcging the expecting one) and 2. to indicate that when the view name is matching, it is not properly configured (Configured: False)

Agreed