Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullup over navbar #30

Open
AdrienDC opened this issue Sep 6, 2016 · 14 comments
Open

Pullup over navbar #30

AdrienDC opened this issue Sep 6, 2016 · 14 comments
Labels

Comments

@AdrienDC
Copy link

AdrienDC commented Sep 6, 2016

Hello,
I recently updated my iphone and I got an issue I didn't have before on IOS 9.3.2.
When I tap on the pullup item it goes beyond where it supposed to go, see the screenshot.

It's happening only on IOS, not Android though... Shall I play with max-height for a workaround?

Thanks !
img_9667

@arielfaur
Copy link
Owner

@AdrienDC I think you are the first one to report this. Are you still having issues?
I wonder if anybody else has experienced this. Seems to work well on my end.

@arielfaur arielfaur added the bug label Sep 12, 2016
@jsanta
Copy link

jsanta commented Sep 12, 2016

Had some similar problem once, because my layout uses a double header line.
Ended adding an overrrideBottom attribute and setting a fixed value for CSS bottom when required. A not-so-nice solution.

@AdrienDC
Copy link
Author

AdrienDC commented Sep 21, 2016

Hello @arielfaur ,
yes still got the problem.. It's like the height of the status bar is not included because I've tried to manually input and I got the same result:
footer.height = footer.maxHeight > 0 ? footer.maxHeight : $window.innerHeight - 93 - 25

Corresponding to the window height minus tabs height and header height.

@arielfaur
Copy link
Owner

I wonder if that happens without tabs. @jsanta did your template have bottom tabs too?

@jsanta
Copy link

jsanta commented Sep 21, 2016

Yes, one of my views has bottom-tabs.
The last time I messed with the code I noticed there was a slight problem with the active view selector in the plugin, haven't seen the updated version.

@AdrienDC
Copy link
Author

Just a thought, are you using StatusBar plugin?
I was wondering if StatusBar.overlaysWebView(false); has any effect.

@arielfaur
Copy link
Owner

So this bug seems to appear only when adding tabs to a template. I am not certain it makes sense at all to have a pullup together with tabs. Both Android and iOS have bottom tabs by default as of the latest version and I am not sure it is a valid use case in terms of usability to show a footer above the tabs. What do you think?

@AdrienDC
Copy link
Author

Bad news.. I think it still make sense to use it with tabs because you may want to display something temporary, for example notifications.. And it shouldn't be above tabs indeed, it should stop when reaching the tabs bar.

@AdrienDC
Copy link
Author

I had to remove 20 pixels to get it right for iOS

@AdrienDC
Copy link
Author

AdrienDC commented Oct 1, 2016

Now it seems to be corrected in iOS 10...

@arielfaur
Copy link
Owner

arielfaur commented Oct 2, 2016

I am now focused on Ionic 2 and will stop any further development of this plugin for Ionic 1 due to lack of time. With Ionic 2 everything seems to run smoother!

@ipleh
Copy link

ipleh commented Dec 2, 2016

Hi!
I think there is mistake in ion-pullup.scss file.

scroll-content {
          margin-bottom: calc(#{$toolbar-ios-height} + #{$tabHeight});
        }

should be

.scroll-content {
          margin-bottom: calc(#{$toolbar-ios-height} + #{$tabHeight});
        }

since scroll-content is a class in div element, not an element himslef.
Hope that will help.

@arielfaur
Copy link
Owner

@ipleh This thread is for the Ionic 1 version. I think you refer to Ionic 2, right?

@ipleh
Copy link

ipleh commented Dec 15, 2016

Right, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants