Removed environment spec #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there should be no guarantee on the internals of environments as they are subject to change
huitseeker
suggested changes
Jan 8, 2024
There was a problem hiding this comment.
So in principle, changing the way environments work is of course OK, but removing these tests seems a bit premature.
Surely we can remove those alongside the PR that modifies environments lurk-side, replacing the current env behavior with one that's newly introduced, instead of blindly removing any constraints on the environments.
Case in point, this test still ran successfully last night:
https://github.com/lurk-lab/lurk-rs/actions/runs/7441540481
huitseeker
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Noting for my context: we have equivalent env tests as part of lurk-lab/lurk-beta#996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no guarantee on the internals of environments as they are subject to change. In fact the environment is currently being modified