Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop hash_poseidon indirection #1193

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: drop hash_poseidon indirection #1193

merged 1 commit into from
Mar 5, 2024

Conversation

arthurpaulino
Copy link
Member

neptune::circuit2::poseidon_hash_allocated already does the is_witness_generator check for performance so we don't need to redo this in lurk-rs

@arthurpaulino
chore: drop hash_poseidon indirection
15e2785 
`neptune::circuit2::poseidon_hash_allocated` already does the
`is_witness_generator` check for performance so we don't need to
redo this in `lurk-rs`
@arthurpaulino arthurpaulino requested a review from a team as a code owner March 5, 2024 02:14
@arthurpaulino
Copy link
Member Author

!gpu-benchmark

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Benchmark for 7a57670

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 5.7±0.04s 5.8±0.03s +1.75%
LEM Fibonacci Prove - rc = 100/fib/num-200 11.4±0.05s 11.5±0.04s +0.88%
LEM Fibonacci Prove - rc = 600/fib/num-100 4.0±0.02s 4.0±0.02s 0.00%
LEM Fibonacci Prove - rc = 600/fib/num-200 6.7±0.01s 6.7±0.02s 0.00%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

!gpu-benchmark action succeeded! 🚀

https://github.com/lurk-lab/lurk-rs/actions/runs/8156465375

@arthurpaulino
Copy link
Member Author

!gpu-benchmark

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Benchmark for 7a57670

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 5.8±0.02s 5.8±0.03s 0.00%
LEM Fibonacci Prove - rc = 100/fib/num-200 11.4±0.06s 11.5±0.06s +0.88%
LEM Fibonacci Prove - rc = 600/fib/num-100 4.0±0.03s 4.0±0.02s 0.00%
LEM Fibonacci Prove - rc = 600/fib/num-200 6.6±0.02s 6.7±0.01s +1.52%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

!gpu-benchmark action succeeded! 🚀

https://github.com/lurk-lab/lurk-rs/actions/runs/8156954977

@arthurpaulino
Copy link
Member Author

Wat
!gpu-benchmark

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

!gpu-benchmark action failed ❌

https://github.com/lurk-lab/lurk-rs/actions/runs/8157331063

@arthurpaulino
Copy link
Member Author

!gpu-benchmark

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Benchmark for 7a57670

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 5.8±0.03s 5.8±0.06s 0.00%
LEM Fibonacci Prove - rc = 100/fib/num-200 11.4±0.03s 11.5±0.03s +0.88%
LEM Fibonacci Prove - rc = 600/fib/num-100 4.0±0.01s 4.0±0.03s 0.00%
LEM Fibonacci Prove - rc = 600/fib/num-200 6.7±0.02s 6.7±0.02s 0.00%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

!gpu-benchmark action succeeded! 🚀

https://github.com/lurk-lab/lurk-rs/actions/runs/8157347048

@arthurpaulino arthurpaulino added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit fe52127 Mar 5, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/use-neptune-poseidon-hash-directly branch March 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurpaulino @huitseeker