LEM match values #1190
Merged
LEM match values #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
suggested changes
Mar 3, 2024
src/lem/interpreter.rs
Outdated
| let ptr = bindings.get_ptr(match_var)?; | ||
| if ptr.tag() != &Tag::Expr(Sym) { | ||
| if ptr.tag() != &tag { | ||
| bail!("{match_var} is not a symbol"); |
There was a problem hiding this comment.
This error message needs to be updated
|
Here's an idea that can be done later:
The rule of thumb is that we should do our best to avoid having inconsistent |
gabriel-barrett
force-pushed
the
lem-match-values
branch
from
c833d1f to
2e749d3
Compare
porcuquine
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the more general match of values, instead of only symbols