Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small util for SuperNova testing (easy) #358

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

wyattbenno777
Copy link
Contributor

added num_constraints_and_variables function

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, if we look at the Nova analogous part, we also return the same values for the secondary:

https://github.com/lurk-lab/arecibo/blob/07f571e11f346ef51d4c4ce3cf14ab0360982a30/src/lib.rs#L326-L340

Now, I 💯 agree with you that the circuit counts at a particular circuit index make more sense, so thanks, this addition is valuable. Would you be up for adding another function returning constraint and variable count for the secondary as well while we're at it?

@wyattbenno777
Copy link
Contributor Author

circuit_shape_secondary

Added!

@huitseeker huitseeker changed the title add small util for SuperNova testing add small util for SuperNova testing (easy) Mar 14, 2024
@huitseeker huitseeker added this pull request to the merge queue Mar 14, 2024
Merged via the queue into argumentcomputer:dev with commit 6133454 Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants