Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a hashchain example (Nova Forward port) #339

Merged
merged 2 commits into from
Feb 22, 2024
Merged

add a hashchain example (Nova Forward port) #339

merged 2 commits into from
Feb 22, 2024

Conversation

huitseeker
Copy link
Contributor

This forward ports the following PR:
microsoft/Nova#311

@srinathsetty @huitseeker
add a hashchain example (argumentcomputer#311)
fafdcbc 
* add a hashchain example

* update crate version

* fix clippy; fmt
@huitseeker
Copy link
Contributor Author

!benchmark --bench recursive-snark --bench recursive-snark-supernova --features cuda,asm

@huitseeker
Copy link
Contributor Author

!benchmark --bench recursive-snark --bench recursive-snark-supernova

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for 346b9cf

Click to view benchmark
Test Base PR %
RecursiveSNARK-NIVC-1/Prove/StepCircuitSize-514444 844.8±12.85ms 840.2±13.18ms -0.54%
RecursiveSNARK-NIVC-1/Prove/StepCircuitSize-6540 47.6±0.23ms 48.0±1.48ms +0.84%
RecursiveSNARK-NIVC-1/Verify/StepCircuitSize-514444 668.5±6.60ms 670.0±5.29ms +0.22%
RecursiveSNARK-NIVC-1/Verify/StepCircuitSize-6540 35.4±0.30ms 35.3±0.51ms -0.28%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-514444 845.5±8.99ms 850.1±9.84ms +0.54%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-6540 47.4±0.28ms 47.5±0.11ms +0.21%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-514444 671.3±6.31ms 670.3±4.13ms -0.15%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-6540 35.4±0.67ms 35.4±0.89ms 0.00%

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for 346b9cf

Click to view benchmark
Test Base PR %
RecursiveSNARK/Prove/StepCircuitSize-0 35.6±0.16ms 35.6±0.13ms 0.00%
RecursiveSNARK/Prove/StepCircuitSize-1038751 1370.5±10.47ms 1384.2±7.60ms +1.00%
RecursiveSNARK/Prove/StepCircuitSize-121247 196.9±0.90ms 196.3±0.81ms -0.30%
RecursiveSNARK/Prove/StepCircuitSize-22943 65.4±0.18ms 65.6±0.22ms +0.31%
RecursiveSNARK/Prove/StepCircuitSize-252319 410.3±0.81ms 409.6±0.87ms -0.17%
RecursiveSNARK/Prove/StepCircuitSize-514463 812.2±9.44ms 809.0±5.73ms -0.39%
RecursiveSNARK/Prove/StepCircuitSize-55711 108.9±0.37ms 109.2±0.71ms +0.28%
RecursiveSNARK/Prove/StepCircuitSize-6559 44.3±0.21ms 44.5±0.27ms +0.45%
RecursiveSNARK/Verify/StepCircuitSize-0 24.0±0.46ms 24.1±0.24ms +0.42%
RecursiveSNARK/Verify/StepCircuitSize-1038751 833.1±8.62ms 833.4±7.48ms +0.04%
RecursiveSNARK/Verify/StepCircuitSize-121247 156.6±3.63ms 155.9±4.67ms -0.45%
RecursiveSNARK/Verify/StepCircuitSize-22943 47.5±1.11ms 47.2±1.01ms -0.63%
RecursiveSNARK/Verify/StepCircuitSize-252319 310.2±8.53ms 308.7±7.84ms -0.48%
RecursiveSNARK/Verify/StepCircuitSize-514463 565.0±3.48ms 565.6±1.45ms +0.11%
RecursiveSNARK/Verify/StepCircuitSize-55711 84.2±1.65ms 84.0±1.26ms -0.24%
RecursiveSNARK/Verify/StepCircuitSize-6559 30.6±0.39ms 30.7±0.48ms +0.33%

@samuelburnham
Copy link
Member

!benchmark --bench recursive-snark --bench recursive-snark-supernova --features cuda,asm

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for 346b9cf

Click to view benchmark
Test Base PR %
RecursiveSNARK-NIVC-1/Prove/StepCircuitSize-514444 194.9±0.99ms 195.0±0.75ms +0.05%
RecursiveSNARK-NIVC-1/Prove/StepCircuitSize-6540 44.5±0.20ms 44.7±0.48ms +0.45%
RecursiveSNARK-NIVC-1/Verify/StepCircuitSize-514444 147.8±4.18ms 148.0±3.75ms +0.14%
RecursiveSNARK-NIVC-1/Verify/StepCircuitSize-6540 34.3±0.36ms 34.4±0.81ms +0.29%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-514444 199.5±1.84ms 189.1±0.61ms -5.21%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-6540 44.5±0.20ms 44.6±0.18ms +0.22%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-514444 151.2±4.25ms 141.1±3.65ms -6.68%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-6540 34.1±0.41ms 34.3±0.40ms +0.59%

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for 346b9cf

Click to view benchmark
Test Base PR %
RecursiveSNARK/Prove/StepCircuitSize-0 33.3±0.29ms 33.1±0.12ms -0.60%
RecursiveSNARK/Prove/StepCircuitSize-1038751 318.6±1.13ms 320.7±1.02ms +0.66%
RecursiveSNARK/Prove/StepCircuitSize-121247 59.8±0.22ms 59.7±0.34ms -0.17%
RecursiveSNARK/Prove/StepCircuitSize-22943 62.5±0.14ms 62.5±0.29ms 0.00%
RecursiveSNARK/Prove/StepCircuitSize-252319 121.3±1.29ms 120.4±0.58ms -0.74%
RecursiveSNARK/Prove/StepCircuitSize-514463 185.7±0.93ms 186.7±0.56ms +0.54%
RecursiveSNARK/Prove/StepCircuitSize-55711 50.5±0.30ms 50.4±0.19ms -0.20%
RecursiveSNARK/Prove/StepCircuitSize-6559 41.8±0.15ms 41.8±0.12ms 0.00%
RecursiveSNARK/Verify/StepCircuitSize-0 23.4±0.39ms 23.4±0.61ms 0.00%
RecursiveSNARK/Verify/StepCircuitSize-1038751 91.8±2.46ms 92.2±2.53ms +0.44%
RecursiveSNARK/Verify/StepCircuitSize-121247 31.8±1.95ms 31.6±1.66ms -0.63%
RecursiveSNARK/Verify/StepCircuitSize-22943 46.4±1.09ms 46.2±0.87ms -0.43%
RecursiveSNARK/Verify/StepCircuitSize-252319 41.5±2.14ms 41.6±1.37ms +0.24%
RecursiveSNARK/Verify/StepCircuitSize-514463 51.0±3.14ms 51.7±1.68ms +1.37%
RecursiveSNARK/Verify/StepCircuitSize-55711 26.9±0.86ms 27.6±1.01ms +2.60%
RecursiveSNARK/Verify/StepCircuitSize-6559 29.9±0.36ms 29.9±0.44ms 0.00%

tchataigner
tchataigner previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@tchataigner tchataigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is only one typo in the comment to run the example

examples/hashchain.rs Outdated Show resolved Hide resolved
tchataigner
tchataigner approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@tchataigner tchataigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huitseeker huitseeker added this pull request to the merge queue Feb 22, 2024
Merged via the queue into argumentcomputer:dev with commit 74792f9 Feb 22, 2024
9 checks passed
@huitseeker huitseeker deleted the hash_chain branch February 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchataigner tchataigner tchataigner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huitseeker @samuelburnham @tchataigner @srinathsetty