chore: Refactors CPU MSM operations using halo2curves library #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
requested review from
adr1anh,
porcuquine,
winston-h-zhang and
mpenciak
- Expanded the `msm` module within the `provider/util` directory and introduced a new function, `cpu_best_msm`. - Changed the curves library dependency in `bn256_grumpkin.rs` from `pasta_curves` to `halo2curves`, - Removed the `msm.rs` file along with two associated functions `cpu_msm_serial` and `cpu_best_msm` used for non-GPU accelerated operations, and all related tests. - Reorganized the import of `CurveAffine, CurveExt` from the `halo2curves` library in `provider/mod.rs`. Fixes argumentcomputer#193
winston-h-zhang
approved these changes
Jan 4, 2024
adr1anh
approved these changes
Jan 4, 2024
samuelburnham
pushed a commit
to samuelburnham/arecibo
that referenced
this pull request
Jan 4, 2024
* Minor tweak (argumentcomputer#225) * Minor tweak * Minor tweak * Revert "Minor tweak" This reverts commit f416f838316d51b4275db53a95238c427e5d3f21. * Formatted with rustfmt * Linted with Clippy * Release 0.24.0 (argumentcomputer#230) * rename TrivialTestCircuit to TrivialCircuit * address clippy warnings * fix docstring --------- Co-authored-by: Junhee Lee <[email protected]> Co-authored-by: Srinath Setty <[email protected]> Co-authored-by: Arthur Paulino <[email protected]>
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 14, 2024
* rename TrivialTestCircuit to TrivialCircuit * address clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msmmodule within theprovider/utildirectory and introduced a new function,cpu_best_msm.bn256_grumpkin.rsfrompasta_curvestohalo2curves,msm.rsfile along with two associated functionscpu_msm_serialandcpu_best_msmused for non-GPU accelerated operations, and all related tests.CurveAffine, CurveExtfrom thehalo2curveslibrary inprovider/mod.rs.Fixes #193
Obviates the forward-port of microsoft/Nova#288