Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hostNodeName to workflow.failures #7473

Open
summylight opened this issue Dec 30, 2021 · 2 comments · May be fixed by #13863
Open

Add hostNodeName to workflow.failures #7473

summylight opened this issue Dec 30, 2021 · 2 comments · May be fixed by #13863
Labels
area/controller Controller issues, panics type/feature Feature request

Comments

@summylight
Copy link

summylight commented Dec 30, 2021 •
edited
Loading

Summary

I'm analyzing workflow.failure to get the message of workflow failure. But sometimes workflow step failed due to node failure, e.g. node OOM, node networkf issue. I want workflow.failures to support posting hostNodeName. As I see, it's simple to add it in https://github.com/argoproj/argo-workflows/blob/master/workflow/controller/operator.go#L105 as we could already get node.hostNodeName here.

Use Cases

The workflow.failures variable is provided to exit-handler step for debug. Since step failed due to node issue sometimes, the workflow failures need to contain a hostNodeName field.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@summylight summylight added the type/feature Feature request label Dec 30, 2021
@summylight
Copy link
Author

I'm willing to post a commit and do test for this, if the argo team have no time.

@alexec alexec added the area/controller Controller issues, panics label Feb 4, 2022
@tooptoop4
Copy link
Contributor

https://github.com/argoproj/argo-workflows/blob/v3.5.11/workflow/controller/operator.go#L452 looks to be where needs to change

@tooptoop4 tooptoop4 linked a pull request Nov 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller Controller issues, panics type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add hostNodeName to workflow.failures (#7473) tooptoop4/argo-workflows
3 participants
@alexec @summylight @tooptoop4