Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) #21298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) #21298

wants to merge 2 commits into from
+20 −1

Conversation

shenxn
Copy link

@shenxn shenxn commented Dec 23, 2024 •
edited
Loading

Fixes #18998. When requesting app refresh with a delay, the request will be stored as a string in the form of <appKey>/<compareWith>. However, the address of compareWith is used instead of its value, causing invalid refresh levels being used.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@shenxn shenxn requested a review from a team as a code owner December 23, 2024 12:25
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 23, 2024 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@shenxn shenxn force-pushed the fix-request-app-refresh-with-delay branch from db80633 to 54b7010 Compare December 23, 2024 12:45
@shenxn
test: add UT
540664d 
Signed-off-by: Xiaonan Shen <[email protected]>
@shenxn shenxn force-pushed the fix-request-app-refresh-with-delay branch from 54b7010 to 540664d Compare December 23, 2024 12:45
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.22%. Comparing base (f15e1bc) to head (540664d).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21298      +/-   ##
==========================================
- Coverage   55.23%   55.22%   -0.01%     
==========================================
  Files         337      337              
  Lines       57055    57055              
==========================================
- Hits        31515    31510       -5     
- Misses      22847    22854       +7     
+ Partials     2693     2691       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Status: Ready for final review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect comparison level displayed in the logs about refreshing app status: 825069003112 instead of 0-3
2 participants
@shenxn @andrii-korotkov-verkada