-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option of specifying which CRD version to use for Grpc #76
Comments
I am in favor of upgrading but @Philipp-Plotnikov will have the final say on this. |
We use stable channel where we can but not all CRD is in the stable channel. GRPCRoute is in v1alpha2(it seems it is named experimental). I didn't see GRPCRoute is stable in GatewayAPI spec. @FredrikAugust did you see it ? If yes, please drop the link, we will upgrade. |
We use stable channel for example for HTTPRoute. |
@kostis-codefresh we had some discussion about versions, am I right ? I remember we decided there to support one last stable version. Am I correct ? |
Yes. Supporting multiple versions at the same time will be super difficult in the long run (with our current team). This is why I suggested upgrading to latest when possible. At least as long as we release 0.x versions. |
I'm not very familiar with versioning of the Gateway API spec (nor CRDs in general for that matter), but on the Gateway API page, under v1, GRPCRoute is listed with It also says on the GRPCRoute page that it is GA in stable channel since v1.1.0. This seems to match up with Traefik helm charts move to stable v1.1.0 (link to line in huge diff so click at your own risk). |
It seems, you are right. I will upgrade it today. |
@FredrikAugust done |
I don't know if this is supported yet in Linkerd, but I've created an issue. From what I can see they still use v1alpha2. |
rollouts-plugin-trafficrouter-gatewayapi/pkg/plugin/grpcroute.go
Line 25 in 43fd59f
Traefik helm chart now uses v1 (stable) for GRPCRoutes, while this plugin uses v1alpha2. Would it be possible to add the option of specifying which version to use, or perhaps upgrade?
The text was updated successfully, but these errors were encountered: