Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support asyncio for workflow service #1266

Open
yulin-li opened this issue Nov 17, 2024 · 1 comment
Open

support asyncio for workflow service #1266

yulin-li opened this issue Nov 17, 2024 · 1 comment
Labels
type:enhancement A general enhancement

Comments

@yulin-li
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. e.g.. I'm always frustrated when [...]

For workflow service actions, such as list/submit workflows, it will be great if an asyncio version is provided in the SDK.

Describe the solution you'd like
A clear and concise description of what you want to happen.

provide an asyncio version of WorkflowsService based on e.g., aiohttp instead of request

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@flaviuvadan
Copy link
Collaborator

flaviuvadan commented Nov 17, 2024

Hi @yulin-li, this is a great idea. Are you open to submit a PR? Hera uses this script https://github.com/argoproj-labs/hera/blob/main/scripts/service.py to generate the workflow service. We need an async_service.py with some templates adjusted and a Make recipe like this. The submit API of cron and workflow have to change as well to account for the async nature of the injected service as well

@elliotgunton elliotgunton added the type:enhancement A general enhancement label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants