Replace NeoPixelBus with TasmotaLED on ESP32x #22556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replace NeoPixelBus with TasmotaLED on ESP32x variants. Tasmota already started to diverge from NeoPixelBus with esp-idf 5.1 support, and we are using only a tiny fraction of the lib.
TasmotaLED focuses only on pushing raw pixels:
RRGGBB
to simplify encoding, conversion toGGRRBB
is done when pushing the buffersdirty
is not needed anymore, pixels are pushed anyways when callingshow()
You can revert to NeoPixelBus with
#define USE_WS2812_FORCE_NEOPIXELBUS
but this disables Berry support.No change on ESP8266
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass