Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NeoPixelBus with TasmotaLED on ESP32x #22556

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Nov 27, 2024

Description:

Replace NeoPixelBus with TasmotaLED on ESP32x variants. Tasmota already started to diverge from NeoPixelBus with esp-idf 5.1 support, and we are using only a tiny fraction of the lib.

TasmotaLED focuses only on pushing raw pixels:

  • support RMT and SPI. RMT is enabled on all RMT compatible devices, SPI is enabled on C2.
  • I2S could be supported, but there is no current need and the code size is significant
  • major change: internal buffers are RRGGBB to simplify encoding, conversion to GGRRBB is done when pushing the buffers
  • dirty is not needed anymore, pixels are pushed anyways when calling show()
  • ArtNet on ESP32 now requires RGB encoding and not GRB anymore

You can revert to NeoPixelBus with #define USE_WS2812_FORCE_NEOPIXELBUS but this disables Berry support.

No change on ESP8266

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit db0287e into arendst:development Nov 27, 2024
59 checks passed
@barbudor
Copy link
Contributor

It looks like this period of the year is a good time to play with flashing leds...
🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants