ADBDEV-4349: gplogfilter: fix timerange validation #1134
+399
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silent-observer
force-pushed
the
ADBDEV-5487
branch
from
e3c6ae7
to
6afd8a8
Compare
maybe change to and add this title to PR description? |
RekGRpth
approved these changes
Nov 29, 2024
|
That's the default way cherry-picked commits work (preserving the PR link from the old PR). Should it always be changed to the new PR? |
yes, to avoid confusion |
Previously the time range filtering of log files was incorrect: there was a check for belonging a log file to specified time range which worked like a binary `AND` (if time < begin AND time > end - skip file), but something like binary `OR` is needed here. Thus file filtering never worked. Also this validation was executed after the file was opened, so in case of failed validation there was a redundant `open/close` operations. This patch fixes such behavior, by: - moving the logic of belonging log file name the user specified range to the separate function (it's also helps to cover corner cases) - skip file processing, if it doesn't belong to range, at the begin of loop to prevent redundant `open/close` operations Changes from original commit: 1. Fix print() syntax for Python 3 2. Add StopIteration handler (required by Python 3.7) 3. Update behave test for GPDB 7 (use COORDINATOR_DATA_DIRECTORY and /log) (cherry picked from commit e971286)
silent-observer
force-pushed
the
ADBDEV-5487
branch
from
6afd8a8
to
87b3a20
Compare
silent-observer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gplogfilter: fix timerange validation
Previously the time range filtering of log files was incorrect: there was a check for belonging a log file to specified time range which worked like a binary
AND(if time < begin AND time > end - skip file), but something like binaryORis needed here. Thus file filtering never worked. Also this validation was executed after the file was opened, so in case of failed validation there was a redundantopen/closeoperations. This patch fixes such behavior, by:open/closeoperationsChanges from original commit:
(cherry picked from commit e971286)
Note: do not squash to preserve authorship