forked from greenplum-db/gpbackup-archive
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV 6061 Add test for doRestoreAgent in gpbackup #102
Open
dkovalev1
wants to merge
34
commits into
master
Choose a base branch
from
ADBDEV-6061
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
RekGRpth
reviewed
Aug 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The same should be done for |
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 17, 2024
whitehawk
reviewed
Aug 23, 2024
whitehawk
reviewed
Aug 23, 2024
whitehawk
reviewed
Aug 23, 2024
whitehawk
reviewed
Aug 23, 2024
whitehawk
reviewed
Aug 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
RekGRpth
reviewed
Oct 11, 2024
RekGRpth
reviewed
Oct 11, 2024
RekGRpth
reviewed
Oct 16, 2024
whitehawk
reviewed
Oct 23, 2024
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
Co-authored-by: Roman Eskin <[email protected]>
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
whitehawk
reviewed
Oct 24, 2024
This comment was marked as resolved.
This comment was marked as resolved.
whitehawk
reviewed
Oct 25, 2024
whitehawk
reviewed
Oct 25, 2024
whitehawk
reviewed
Oct 25, 2024
whitehawk
reviewed
Oct 29, 2024
whitehawk
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for doRestoreAgent with interface mocking.
This PR proposes to add mocking interfaces and unit test for the
doRestoreAgent() function in the gprestore.
When we look at the gprestore code, and into doRestoreAgent() in particular,
there is not so trivial logic which might be difficult to cover with the
end-to-end and integration tests. From the other side this logic relies on
numerous external dependencies which makes unit testing nearly impossible.
This commit proposes using of well-known mocking technique for unit testing of
gpbackup code with an example based on gprestore and doRestoreAgent(). With
interface mocking it becomes possible to:
external dependencies, tests will be more stable
However, this approach only complements existing end-to-end and integration
tests, it's not intended to replace them. The outcome heavily relies on the
clarity and quality of mock interfaces; it's easy to achieve unintended results.
The idea for mocking is to replace complex objects with their test imitation.
Unfortunately, gpbackup is written in solid manner, and it's not possible to
just replace built-in functions. To mitigate it, internal dependencies are split
with introducing of interfaces for dependencies external related to code under
test. Production code is using production interface implementation, while in
testing code we use test implementation, which does do only things related to
the test and return values exactly for the test scenario.
This commit adds the following interfaces:
helper/restore_helper.go
whether the command has already been ended
This is a minimum change for the supplied tests. It's expected that when more
methods or interfaces will be needed they will be created of necessity. The
changes for the interface introduction are minimal and straightforward.
Test logic is located in the helper/helper_test.go.