Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Enum-like objects #2621

Open
e-moran opened this issue Dec 18, 2024 · 3 comments · May be fixed by #2684
Open

Deprecate Enum-like objects #2621

e-moran opened this issue Dec 18, 2024 · 3 comments · May be fixed by #2684
Assignees
@e-moran

Comments

@e-moran
Copy link
Contributor

e-moran commented Dec 18, 2024 •
edited
Loading

This issue is related to #1833.

We must first deprecate the Enum-like objects before we remove them though.

We should add JSDoc so editors apply strikethrough to any usage and a changelog entry.
@e-moran e-moran self-assigned this Dec 18, 2024
@e-moran e-moran mentioned this issue Dec 18, 2024
Open
@blaine-arcjet
Copy link
Contributor

I don't think we should add a warning log. I think we should add JSDoc so editors apply strikethrough to any usage and a changelog entry.

@davidmytton
Copy link
Contributor

Agree that adding a warning is not ideal because it could pollute the logs on every request. Let's use the doc comments and include it in the change log/release notes.

@e-moran
Copy link
Contributor Author

e-moran commented Dec 19, 2024

Sounds good! I've updated the issue

@e-moran e-moran linked a pull request Dec 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-moran e-moran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate: arcjet enum-like objects arcjet/arcjet-js
3 participants
@davidmytton @e-moran @blaine-arcjet