Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of performance metric collection/logging #2020

Open
blaine-arcjet opened this issue Oct 22, 2024 · 0 comments
Open

Improve performance of performance metric collection/logging #2020

blaine-arcjet opened this issue Oct 22, 2024 · 0 comments

Comments

@blaine-arcjet
Copy link
Contributor

In #2019, we ensured the performance metric collection and logging was scoped correctly, but this introduced a closure that captures the label and start time. We should investigate the performance of this—perhaps generating symbols and putting them in a Map is better than closures.

At very least, we should no-op the performance metric functions if loglevel is not debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant