Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor wording error - alititude angle is technically calculated as the zenith angle #54

Open
pjayathissa opened this issue Mar 20, 2021 · 0 comments
Assignees

Comments

@pjayathissa
Copy link
Collaborator

pjayathissa commented Mar 20, 2021

Altitude is the angle to the horizontal plane (horizon). But we use the Zenith, which is the angle of the sun relative to the vertical plane. For examples our vertically mounted windows face 90degrees. Which is 90degrees zenith (technically 0 degrees altitude). So all variables such as alitutde_rad, and alititude_tile, sun_alititude, should have altitude replaced with zenith

@pjayathissa pjayathissa self-assigned this Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant