Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emission system change #51

Open
bocaj1988 opened this issue Nov 4, 2020 · 1 comment
Open

emission system change #51

bocaj1988 opened this issue Nov 4, 2020 · 1 comment

Comments

@bocaj1988
Copy link

Hey

When changing the emision system (NewRadiator, OldRadiator...), there are no effect on the result, when running the annualsimulation.
I tried looking at the source code, but with no succes..

hope somone can help

@pjayathissa
Copy link
Collaborator

Hi @bocaj1988 thanks for your comment. The difference between the New and the Old radiators is the supply temperature. There is no difference in energy consumption. If however your supply system is sensitive to supply temperatures. Such as a heat pump. Then you should have an effect on the result. However if your supply system does not have this sensitivity. For example, if it is a boiler, or plain electric heater, then there will be no difference in the result.

class OldRadiators(EmissionSystemBase):
    """
    Old building with radiators and high supply temperature
    Heat is emitted to the air node
    """

    def heat_flows(self):
        flows = Flows()
        flows.phi_ia_plus = self.energy_demand
        flows.phi_st_plus = 0
        flows.phi_m_plus = 0

        flows.heating_supply_temperature = 65
        flows.heating_return_temperature = 45
        flows.cooling_supply_temperature = 12
        flows.cooling_return_temperature = 21

        return flows


class NewRadiators(EmissionSystemBase):
    """
    Newer building with radiators and medium supply temperature
    Heat is emitted to the air node
    """

    def heat_flows(self):
        flows = Flows()
        flows.phi_ia_plus = self.energy_demand
        flows.phi_st_plus = 0
        flows.phi_m_plus = 0

        flows.heating_supply_temperature = 50
        flows.heating_return_temperature = 35
        flows.cooling_supply_temperature = 12
        flows.cooling_return_temperature = 21

        return flows

If however you are using a system such as a heat pump, and there are no changes, then there may be a bug in the code. In this case, can you please send me your source code. Ideally, make a fork, upload your code, and send me that link so I can check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants