Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheme reports/forms section: "License" #121

Open
robgaston opened this issue Nov 6, 2024 · 4 comments
Open

Scheme reports/forms section: "License" #121

robgaston opened this issue Nov 6, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@robgaston
Copy link
Member

preamble

to build out the sections of the scheme forms/reports we will need to:

  1. define mappings between form/report fields and the Lingo models
  2. implement backend serializers/APIs
  3. implement front end UI

mapping issues

scheme license:rights

It's not clear where in the model these data are stored, but I suspect it is in the "Rights" nodegroup & its children. Is this correct? the fields don't seem to align in any meaningful way, so I assume i've either not identified the right nodegroup or the mockups are not complete relative to the model.

@Habennin @Philbox @dwuthrich we should discuss & resolve the above questions as they will be blockers to development here. thanks!

@robgaston robgaston added the question Further information is requested label Nov 6, 2024
@Philbox
Copy link

Philbox commented Nov 7, 2024

@robgaston I'm not sure what Version means in the UI here but there is a version nodegroup which is intended to record the version of a published scheme. I'm not sure if we ever nailed down what exactly constitutes a version.
I think that the licence does/should refer to the Rights group and will be the Rights Statement
The licence is intended to specify what rights affect the use of the vocabulary. For example we make ours available under the open government licence https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/

@Habennin will know more about the modelling

@Habennin
Copy link

Habennin commented Nov 7, 2024

I agree with @Philbox , rights version is not something foreseen in the modelling as a separate field. Rather the idea was that you have a controlled list of rights types like CC BY 4 and if there is a version maybe there is a child CCBY 4, Version 4 or something like that. No need in my opinion for an extra field to put the version of the right type in.

What is foreseen is putting who the right belongs to and also a statement field to put further information or to just write out what your rights information is if you don't use a stanard license. So basically what is foreseen in the model is the whole node group.

From the mockup the closest field is right_type.

Screenshot 2024-11-07 at 4 59 41 PM

@robgaston
Copy link
Member Author

@dwuthrich what did we have in mind when mocking this up? does right_type seem to fit this? wondering if we should be exposing other fields related to this in Lingo as the nodegoups are much richer than that one field

@robgaston
Copy link
Member Author

The license section should probably be renamed "Scheme Rights", which will include the type and holder drop downs. This tile is cardinality 1 and will be the parent of the rights statements. We can then add another section for "Scheme Rights Statements" which can manage the fields that make up the right_statement (cardinality n). This section will be similar to the "Scheme Notes" section.

@chrabyrd we should be unblocked on these (now 2) sections of the Scheme forms/reports.

Note: we will need to mockup data for the "right_type" and "right_holder" dropdowns. @Habennin can you please take a look at the right_type controlled list as you look at the CLM generally and ensure that we populate it with the right entries? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants