Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiosk: deleting site as identifier in edit file dialogue leads to incorrect modified field #2935

Open
luizaogs opened this issue Oct 29, 2024 · 6 comments
Assignees
Labels
🐞 bug Something isn't working kiosk a kiosk issue (not a filemaker issue) new-issue issue needs to be reviewed and labels and projects need to be added. Remove afterwards.

Comments

@luizaogs
Copy link
Collaborator

Issue found in testing the first bullet point in #2807

Added the context LA to image 5245b723-d45b-416f-bd2a-632089af4031 at around 8:20ish Pacific Time, 28 X 2024. The modified field does not reflect that addition:

Screenshot 2024-10-28 at 8 26 36 PM
@luizaogs luizaogs added 🐞 bug Something isn't working kiosk a kiosk issue (not a filemaker issue) new-issue issue needs to be reviewed and labels and projects need to be added. Remove afterwards. labels Oct 29, 2024
@luizaogs luizaogs changed the title kiosk: adding context to file in edit dialog does not change modified time kiosk: adding and deleting contexts to files in edit dialog does not change modified time Oct 29, 2024
@luizaogs
Copy link
Collaborator Author

Same issue for deletion. Deleted a context from image f2c07043-8b8b-4dd8-9b0c-3159910e0c7c around 8:28pm Pacific Time and the modified field does not reflect that:

Screenshot 2024-10-28 at 8 30 00 PM

@luizaogs
Copy link
Collaborator Author

Um, weirder - don't know if you want a separate ticket.

Tried deleting site PVD from image 86c7ad59-27a9-4425-9f51-91b7662c7ee8 and that DID get the modified field changed. But it changed incorrectly, to Eastern time when it should be Pacific time (as reflected in the timezone under my user icon in the Hub). BUT it also didn't delete the identifier. If I click out of the file edit dialog and back in, PVD is still there (though the modified field has changed, even if incorrectly).

Screenshot 2024-10-28 at 8 33 00 PM

@urapadmin
Copy link
Collaborator

ja, it tripped me up, too, again: Adding / Deleting a context must not change the image's own timestamp. That would be wrong.
The time stamp of adding it would be reflected in the record that connects the image to the context. So in LA dayplans. In Q&V in the dayplans or in the recording app you should see the correct modification ts.

That's why my list in #2807 is misleading. Deleting really does not do anything at all and modifying is deleting and then adding, so the same as adding.

@urapadmin
Copy link
Collaborator

Um, weirder - don't know if you want a separate ticket.

Tried deleting site PVD from image 86c7ad59-27a9-4425-9f51-91b7662c7ee8 and that DID get the modified field changed. But it changed incorrectly, to Eastern time when it should be Pacific time (as reflected in the timezone under my user icon in the Hub). BUT it also didn't delete the identifier. If I click out of the file edit dialog and back in, PVD is still there (though the modified field has changed, even if incorrectly).
Screenshot 2024-10-28 at 8 33 00 PM

well, ja, that is weird on two fronts: You cannot delete an image from site or add an image to site (it would need #616 to change that). That's an oooold issue I have never gotten to. So the first issue here is that I am allowing something that I shouldn't (but I'd rather tackle #616 than change that).

Why the modification date changes, though, I don't know. That is indeed an issue then.

@luizaogs
Copy link
Collaborator Author

Right then, I guess I’ll change the name of the ticket? Or do you want a new one?

@urapadmin
Copy link
Collaborator

new name would be great. This must be a very site map specific issue.

@luizaogs luizaogs changed the title kiosk: adding and deleting contexts to files in edit dialog does not change modified time kiosk: deleting site as identifier in edit file dialogue leads to incorrect modified field Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working kiosk a kiosk issue (not a filemaker issue) new-issue issue needs to be reviewed and labels and projects need to be added. Remove afterwards.
Projects
None yet
Development

No branches or pull requests

2 participants