Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hm: remove excess relations #2572

Closed
urapadmin opened this issue Mar 7, 2024 · 7 comments
Closed

hm: remove excess relations #2572

urapadmin opened this issue Mar 7, 2024 · 7 comments
Assignees
Labels
kiosk a kiosk issue (not a filemaker issue)
Milestone

Comments

@urapadmin
Copy link
Collaborator

urapadmin commented Mar 7, 2024

Originally posted by @urapadmin in #2402 (comment)

  • Once and for all: Since nobody has ever given me a really conclusive reason why two nodes can possibly have two relations to each other, I will now officially drop that possibility until somebody actually has a valid example in the field. @lbestock: Only so that you know.
@urapadmin urapadmin added the kiosk a kiosk issue (not a filemaker issue) label Mar 7, 2024
@urapadmin urapadmin added this to the Kiosk 1.6 milestone Mar 7, 2024
@urapadmin urapadmin moved this to In Progress in Harris Matrix Mar 7, 2024
@urapadmin
Copy link
Collaborator Author

urapadmin commented Mar 7, 2024

plugin 0.13

This gets more and more problematic and I am loosing a lot of time wrestling with multiple recording issues, some of which cannot really happen anymore with our current version of the recording system. This is now how it is:

  • duplicate relations with chronological impact are removed from the graph but shown in the error panel under "relations, dropped for other reasons". They need to be separate from the cyclic / contradictory relations for current technical reasons. They are marked with two arrows pointing in the same direction.
  • relations dropped due to missing chronological information appear in the same part of the error panel. They are marked with the already introduced triangular exclamation icon.

@urapadmin urapadmin changed the title hm: remove duplicate relations hm: remove excess relations Mar 7, 2024
@urapadmin
Copy link
Collaborator Author

urapadmin commented Mar 7, 2024

@lbestock FA needs a fresh look now that we have this error type: It seems to have excess relations, too.

@luizaogs
Copy link
Collaborator

luizaogs commented Mar 8, 2024

This looks fine in terms of icons, but I leave it open for @lbestock to look at FA.

@lbestock
Copy link
Collaborator

lbestock commented Mar 8, 2024

I am very late to this party and only trying to wrap my head around it now.

@urapadmin I have noted that you do not allow two relations between the same loci and I have read my Harris and I accept this.

Why do some units have an error sign in the menu so that I can toggle the error pane on and off (CC) and other units simply have the error pane visible and I can't turn it off (FA, FI, CA)? Those only have relations removed for other reasons, not cyclic ones, but it still should be possible to toggle the pane off, right?

This probably already has a ticket but post-testing there should be a key so the error icons can be easily understood.

Now for FA...

@lbestock
Copy link
Collaborator

lbestock commented Mar 8, 2024

There are two FA excess relations and they are indeed just excess, one totally just made twice, same relationship even. So things look good to me with FA.

@luizaogs
Copy link
Collaborator

luizaogs commented Mar 8, 2024

There is a ticket for the error panel issue, I believe, but not for a key (which would indeed be helpful). I think if we create a key ticket this one can be closed?

@lbestock
Copy link
Collaborator

lbestock commented Mar 8, 2024

I added the key to #2576, so closed this shall be.

@lbestock lbestock closed this as completed Mar 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Harris Matrix Mar 8, 2024
@github-project-automation github-project-automation bot moved this to Closed in testing Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kiosk a kiosk issue (not a filemaker issue)
Projects
Status: Done
Status: Closed
Development

No branches or pull requests

3 participants