Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour on callbacks #6

Open
ecarlotti opened this issue Feb 27, 2019 · 0 comments
Open

Inconsistent behaviour on callbacks #6

ecarlotti opened this issue Feb 27, 2019 · 0 comments

Comments

@ecarlotti
Copy link

First of all let me start by saying this component saved me a lot of time and work, and it was exactly what I was looking for.

The only issue I could find is that the onDelete callback has inconsistent behaviour when compared to onCreate and onEdit. Both callbacks are called INSTEAD of the original code, whereas onDelete is called only after the alert with the default message ('Delete item?') as show in collectionTable.coffee:233. The correct behaviour should be to call onDelete if it is set FIRST, then proceed to the default behaviour if it is not set.

It is a very simple fix (and I can do it for you if you allow me to).
Is it possible to fix it??

Thanks in advance,
/Edson Carlotti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant