Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploying executor and always true condition #616

Merged
merged 6 commits into from
Nov 5, 2024
Merged

deploying executor and always true condition #616

merged 6 commits into from
Nov 5, 2024

Conversation

novaknole
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

Rekard0
Rekard0 previously approved these changes Oct 29, 2024
View reviewed changes
@novaknole @Rekard0
condition restrictions (#617)
c951efe 
* condition restrictions

* fix isGranted (#618)

---------

Co-authored-by: Rekard0 <[email protected]>
@novaknole novaknole merged commit 5e34b7b into develop Nov 5, 2024
15 of 17 checks passed
@novaknole novaknole deleted the feature/deploy-executor-and-condition branch November 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauBv23 clauBv23 clauBv23 left review comments

@Rekard0 Rekard0 Rekard0 left review comments

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novaknole @Rekard0 @clauBv23