-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): PluginRepo
refactor part II
#589
Conversation
Co-authored-by: Michael Heuer <[email protected]>
…itialVersion function
158a919
to
6d235d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my insights on this matter
Currently, the createVersion
function handles both the creation of new plugin versions and the definition of the initial one if none exists. However, with the upcoming addition of the ability to initialize plugin versions to specific builds, it might be a good time to separate these duties.
The idea would be to redefine the responsibilities of the createVersion
function to focus solely on generating new plugin versions based on provided release information. And introduce a new function, initializePluginVersion
(or a similar name), dedicated exclusively to initializing plugin versions to specific releases and builds, or to the first one if they are zero.
This new function will be called only once because is for initialization purposes only, while the createVersion
one could be called every time a new version is needed.
/// @param _pluginSetup The address of the plugin setup contract. | ||
/// @param _buildMetadata The build metadata URI. | ||
/// @param _releaseMetadata The release metadata URI. | ||
function updateVersionMappings( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convention is to prefix internal variables and methods with an underscore
Description
Task ID: OS-1330
Type of change
See the framework lifecycle in
packages/contracts/docs/framework-lifecycle
to decide what kind of change this pull request is.Checklist:
CHANGELOG.md
file in the root folder.DEPLOYMENT_CHECKLIST
file in the root folder.UPDATE_CHECKLIST
file in the root folder.