Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Aragon plugins from the OSx core repository #588

Merged
merged 45 commits into from
May 3, 2024
Merged

refactor: remove Aragon plugins from the OSx core repository #588

merged 45 commits into from
May 3, 2024

Conversation

jordaniza
Copy link

@jordaniza jordaniza commented Apr 30, 2024 •
edited by jira bot
Loading

Description

Removes plugins from OSx core package into separate plugin repositories:

  • Token Voting -> aragon/token-voting-plugin
  • Multisig -> aragon/multisig-plugin
  • Admin -> aragon/admin-plugin

Deleted AddressList as it is unused.

The full list of changes is itemised in the changelog and has been discussed at length by the OS team.

Task ID: OS-1307

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

jordaniza and others added 30 commits April 4, 2024 15:37
@jordaniza
f: updated the schema to use transaction actions and update the ids
10be7d4
@jordaniza
feat: tests pass for the TransactionAction and Action but fail on Tra…
75a77cd 
…nsfers
@jordaniza
tests: added support for dao_v1_0_0 handler
1af09f3
@jordaniza
f: updated transfer events to use transactionActions and updated 1.3.…
dc156ef 
…0 tests
@jordaniza
f: added dao_v1_0_0 tests
989eaaf
@jordaniza
lint: silenced warnings in files changed
bdd3747
@jordaniza
chore: updated changelog
3637ebc
@jordaniza
fix: re-ordered ids to use caller first, then daoAddress
d1ea038
@jordaniza
test: added tests for deterministic ids
6fac89b
@jordaniza @novaknole
Update packages/subgraph/src/dao/dao_v1_0_0.ts
689f621 
Co-authored-by: Giorgi Lagidze <[email protected]>
@jordaniza
fix: removed dead code and change comment
54f6835
@jordaniza
Merge branch 'f/split-transaction-actions' of https://github.com/arag…
ee65068 
…on/osx into f/split-transaction-actions
@jordaniza
fix: minor suggestions from codereview
af9a23f
@jordaniza
Update CHANGELOG.md
2edf6ef
@jordaniza
f: removed start and end date from tx actions and made entities immut…
cbe67a1 
…able
@jordaniza
lint: fixed eslint subgraph warnings
e000d2f
@jordaniza
lint: fixed prettier on root
f3a8f2d
@jordaniza
lint: fix prettier warnings on root with node 16
9991e2c
@jordaniza
lint: replaced throw with warn to not introduce breaking change
1826f06
@jordaniza
revert: tsconfig changes
1a9427d
@jordaniza
Merge pull request #568 from aragon/f/split-linting
f9e5497 
F/split linting
@jordaniza
Merge pull request #569 from aragon/f/split-immutable-transactionAction
146903c 
f: removed start and end date from tx actions and made entities immut…
@jordaniza @clauBv23
Update packages/subgraph/src/dao/utils.ts
9bb498d 
Co-authored-by: Claudia Barcelo <[email protected]>
@jordaniza
fix: typo
1aa9cb4
@jordaniza
Merge pull request #562 from aragon/f/split-transaction-actions
f1049ff 
F/split transaction actions
@jordaniza
f: split schema now builds
b7b99b8
@jordaniza
tests: tests pass for the subgraph
55fbd73
@jordaniza
mv: rename transactionActions to actionBatch
23560fb
@jordaniza
Update CHANGELOG.md
ef716d6
@jordaniza
f: small changes to documentation and removed some constants
c04f65a
@jordaniza jordaniza marked this pull request as draft April 30, 2024 11:24
@jordaniza jordaniza marked this pull request as ready for review May 1, 2024 15:32
@jordaniza jordaniza marked this pull request as draft May 1, 2024 15:39
@jordaniza jordaniza marked this pull request as ready for review May 1, 2024 15:41
@heueristik heueristik changed the title f: Remove Aragon plugins from the OSx core repository feat: remove Aragon plugins from the OSx core repository May 2, 2024
@Rekard0 Rekard0 changed the title feat: remove Aragon plugins from the OSx core repository refactor: remove Aragon plugins from the OSx core repository May 3, 2024
Rekard0
Rekard0 previously approved these changes May 3, 2024
View reviewed changes
@jordaniza jordaniza requested review from Rekard0 and banasa44 May 3, 2024 10:33
heueristik
heueristik reviewed May 3, 2024
View reviewed changes
yarn.lock Show resolved Hide resolved
heueristik
heueristik approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The ethersproject dependencies in yarn.lock should be revisited in the follow-up task OS-1343.

@jordaniza jordaniza merged commit e79b857 into develop May 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banasa44 banasa44 banasa44 approved these changes

@heueristik heueristik heueristik approved these changes

@novaknole novaknole Awaiting requested review from novaknole

@clauBv23 clauBv23 Awaiting requested review from clauBv23

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordaniza @Rekard0 @heueristik @banasa44 @novaknole