Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-1462 feature/update dao facotry to return plugin and support no plugin daos #619

Merged
merged 17 commits into from
Nov 15, 2024
Merged

OS-1462 feature/update dao facotry to return plugin and support no plugin daos #619

merged 17 commits into from
Nov 15, 2024
+469 −287

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Oct 31, 2024 •
edited
Loading

Description

This PR updates the DAO factory to implements the functionalities:

  • allow creating a DAO without plugins
  • Return necessary data when a DAO is created with plugins

Additionally it will improve the gas efficiency of DAO creation

Task ID: OS-1462

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

Base automatically changed from feature/deploy-executor-and-condition to develop November 5, 2024 12:45
@Rekard0 Rekard0 changed the title feature/update dao facotry to return plugin and support no plugin daos OS-1462 feature/update dao facotry to return plugin and support no plugin daos Nov 5, 2024
@Rekard0 Rekard0 marked this pull request as ready for review November 5, 2024 15:19
@Rekard0 Rekard0 requested review from novaknole and clauBv23 and removed request for novaknole and clauBv23 November 5, 2024 15:19
@Rekard0 Rekard0 merged commit 16c4d4c into develop Nov 15, 2024
15 of 17 checks passed
@Rekard0 Rekard0 deleted the feature/update-dao-factory branch November 15, 2024 13:14
@Rekard0
Copy link
Contributor Author

Rekard0 commented Nov 15, 2024

revied and approved on a call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekard0 @novaknole @clauBv23