Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 🚧 feature: new pm sop #603

Closed
wants to merge 36 commits into from
Closed

WIP 🚧 feature: new pm sop #603

wants to merge 36 commits into from

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Aug 21, 2024

Description

WIP

Task ID: OS-1476

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

Giorgi Lagidze and others added 30 commits July 24, 2024 13:34
…d for the validation while not implementing that method cause it doesnt improve readability that much of the contract as a whole
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ nivida
✅ novaknole
❌ Giorgi Lagidze


Giorgi Lagidze seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@clauBv23 clauBv23 closed this Aug 21, 2024
@clauBv23 clauBv23 reopened this Aug 22, 2024
@clauBv23 clauBv23 changed the title feature: new pm sop WIP 🚧 feature: new pm sop Aug 22, 2024
@novaknole
Copy link
Contributor

Closed in favor of #604

@novaknole novaknole closed this Sep 3, 2024
@novaknole novaknole deleted the feature/new-pm-sop branch October 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants