Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump OZ dependencies to 4.9.3 and add protocolVersion #454

Merged
merged 33 commits into from
Sep 28, 2023
Merged

chore: Bump OZ dependencies to 4.9.3 and add protocolVersion #454

merged 33 commits into from
Sep 28, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Aug 28, 2023 •
edited
Loading

Description

Task: OS-656

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik
refactor: dao signature validation
ea5dcf9
@heueristik
chore: maintained changelog
44972c2
@heueristik
test: test default behaviour when no permission is granted
b8bcc40
@heueristik
refactor: removed unused ERC1271Mock contract
8d94efc
@heueristik
chore: maintained changelog
63d31a8
@heueristik
chore: maintained changelog
9cd233d
@heueristik
refactor: deprecation of variables and functions
4a1420f
@heueristik
Merge remote-tracking branch 'origin/develop' into feature/OS-669-dao…
9a283ab 
…-refactoring
@heueristik
chore: bump protocol version to v1.4.0
78d9b64
@heueristik
chore: maintained changelog
1011871
@heueristik
refactor: use removed instead of depreacted
aca7c5e
@heueristik
Merge remote-tracking branch 'origin/develop' into feature/OS-669-dao…
98f939c 
…-refactoring
@heueristik
chore: bump package versions
33d144f
@heueristik
Merge remote-tracking branch 'origin/develop' into feature/OS-669-dao…
9224721 
…-refactoring
@heueristik
fix: wrong error name
ca012cc
@heueristik
fix: wrong version number in changelog
602e22c
@heueristik
chore: bump OpenZeppelin dependencies
65ece79
@heueristik
chore: use non-draft OpenZeppelin contracts
5baed3d
@heueristik
feature: added protocol version and adapted tests
539893b
@heueristik
feat: added more tests
bffefe5
@heueristik
feat: more tests
fc8d85e
@heueristik heueristik changed the title Feature/os 656 oz dependency bump Bump OZ dependency to 4.9.3 Aug 28, 2023
@heueristik heueristik changed the title Bump OZ dependency to 4.9.3 Bump OZ dependency to 4.9.3 and add protocolVersion Aug 28, 2023
@heueristik heueristik changed the base branch from develop to feature/OS-669-dao-refactoring August 28, 2023 12:48
@heueristik heueristik marked this pull request as ready for review August 28, 2023 13:06
mathewmeconry
mathewmeconry suggested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some protocolVersions as discussed this morning

@heueristik
Copy link
Contributor Author

Changed here: 9e8cbf9

@heueristik heueristik changed the base branch from feature/OS-669-dao-refactoring to develop August 31, 2023 13:52
Rekard0
Rekard0 reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you or Could you confirm that those interfaces https://github.com/aragon/osx/blob/develop/packages/subgraph/src/utils/constants.ts#L26
didn't change?

mathewmeconry
mathewmeconry previously approved these changes Sep 1, 2023
View reviewed changes
@heueristik heueristik mentioned this pull request Sep 1, 2023
Merged
13 tasks
@heueristik
Copy link
Contributor Author

Have you or Could you confirm that those interfaces https://github.com/aragon/osx/blob/develop/packages/subgraph/src/utils/constants.ts#L26 didn't change?

We do this in https://aragonassociation.atlassian.net/browse/OS-694

@heueristik heueristik force-pushed the feature/OS-656-oz-dependency-bump branch from d52c496 to 760174e Compare September 26, 2023 15:53
@heueristik
Copy link
Contributor Author

heueristik commented Sep 26, 2023 •
edited
Loading

@mathewmeconry I improved the NatSpec for ProtocolVersion db7c925 as discussed in our previous call.

@heueristik heueristik force-pushed the feature/OS-656-oz-dependency-bump branch from 760174e to db7c925 Compare September 26, 2023 15:57
Rekard0
Rekard0 previously approved these changes Sep 27, 2023
View reviewed changes
@heueristik heueristik merged commit 1c7b8ec into develop Sep 28, 2023
11 checks passed
@heueristik heueristik deleted the feature/OS-656-oz-dependency-bump branch September 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0