Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve#36 1 #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solve#36 1 #75

wants to merge 4 commits into from

Conversation

schplurtz
Copy link

Hi,

This is a sligthly modified version of the proposed solution to #36 by original author Willi Mann.

it fixes #36

It also solves Debian bug #947425 by Willi Mann, and my own report #973927 which happens to be a duplicate.

I also bumped version to 0.5.13

Hope you'll like it.

Willi Mann and others added 4 commits December 3, 2020 09:40
The first thing UserTable::OnEvent does is to Dispose(). This
deletes all watches making all pointers to watches invalid.
But the original watch is needed to exand the $@ path.
This gets the string out of the watch before it is deleted by
Dispose() and the pointer becomes invalid.
also stick to apparent naming convention.
@Nikoh77
Copy link

Nikoh77 commented Jan 3, 2021

hi guys, i am same problem, is incron stiil in development?
This bug is a big bug... can someone investigate and solve please?
I am on ubuntu server 20.04 and incron 5.12

@galaxy4public
Copy link

@schplurtz , have you looked at #45, where I was fixing the same issue (back in 2018)? Just asking. :)

@Nikoh77
Copy link

Nikoh77 commented Feb 13, 2021

@schplurtz , have you looked at #45, where I was fixing the same issue (back in 2018)? Just asking. :)

It seems not fixed to me, this bug still occurr on my system.

@schplurtz
Copy link
Author

schplurtz commented Mar 7, 2021

Hi @galaxy4public . Sorry for the delay

@schplurtz , have you looked at #45, where I was fixing the same issue (back in 2018)? Just asking. :)

I saw it but not until I was about to submit my PR... :-(. As you say, it fixes #36 too. I was just a bit scared by it, because I could not evaluate whether the code relocation would have other effects, for the better or the worse...

Let's hope one the 2 PR gets merged one day.

@holubovskyi
Copy link

Hello @ar-, first of all, thank you for the incron project. I really like this tool but this problem #36 is causing a lot of pain. Can you possibly review this pull request?

@patricksebastien
Copy link

@schplurtz For me this PR doesn't fix the issue, but the fix from @galaxy4public is working.
galaxy4public@134900e

avcbvamorec added a commit to avcbvamorec/incron that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent segmentation faults upon creating directories
5 participants