-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve#36 1 #75
base: master
Are you sure you want to change the base?
Solve#36 1 #75
Conversation
The first thing UserTable::OnEvent does is to Dispose(). This deletes all watches making all pointers to watches invalid. But the original watch is needed to exand the $@ path. This gets the string out of the watch before it is deleted by Dispose() and the pointer becomes invalid.
also stick to apparent naming convention.
hi guys, i am same problem, is incron stiil in development? |
@schplurtz , have you looked at #45, where I was fixing the same issue (back in 2018)? Just asking. :) |
It seems not fixed to me, this bug still occurr on my system. |
Hi @galaxy4public . Sorry for the delay
I saw it but not until I was about to submit my PR... :-(. As you say, it fixes #36 too. I was just a bit scared by it, because I could not evaluate whether the code relocation would have other effects, for the better or the worse... Let's hope one the 2 PR gets merged one day. |
@schplurtz For me this PR doesn't fix the issue, but the fix from @galaxy4public is working. |
Hi,
This is a sligthly modified version of the proposed solution to #36 by original author Willi Mann.
it fixes #36
It also solves Debian bug #947425 by Willi Mann, and my own report #973927 which happens to be a duplicate.
I also bumped version to 0.5.13
Hope you'll like it.