Enable Collection Owner feature #15419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate txns * remove api key * generate txn for defualt cti
* typo * update changelog * fix changelog * fix typo --------- Co-authored-by: Zekun Wang <[email protected]>
…n Mainnet (#15146) * add tests to gate v2 features in framework * remove change in framework code * linter --------- Co-authored-by: Zekun Wang <[email protected]>
* [forge] check for necessary images only * [gha] fix forge stable parallelism bug * set name for run step as forge test name
This PR implements some major improvements to the astifier: - Finally (I think) cracked the way how to do correct topological sorting and managing nested blocks. More complicated examples now produce more reasonable results. - Rewrote AST transformations for if-then-else and loops. - Fixed issues with the fixpoint analysis on the AST - Did some minor fixes in the sourcifier The generated source is still not correct in some cases, but much better then before.
…ase (#15173) * fix * add error only when there isn't one
* remove keyless circuit * remove keyless circuit unit test
* fix bug in loop unrolling * ast generator tests * decompiler tests * fix
## Description As TPS has improved, increase the TPS of the graceful overload test to more properly test overload. (The current "overload" could almost be reached at peak TPS.) ## How Has This Been Tested? Run the test, see TPS -- it now shows overload
* generate ans transactions * formatting * remove unneeded txns
sherry-x
reviewed
Nov 27, 2024
| - FeatureFlag: | ||
| enabled: | ||
| - collection_owner | ||
| disabled: [] |
There was a problem hiding this comment.
you don't need "disabled" either
There was a problem hiding this comment.
also, target this PR on 1.23 branch.
JohnChangUK
requested review from
alinush,
heliuchuan,
a team,
msmouse,
lightmark,
grao1991,
JoshLind,
zekun000,
bchocho,
gregnazario,
banool,
sasha8,
gelash,
ibalajiarun,
davidiw,
movekevin,
runtian-zhou,
danielxiangzl,
areshand,
junkil-park,
wrwg,
georgemitenkov,
vgao1996 and
0xmaayan
as code owners
|
Updated PR: #15420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of AIP 95 collections permissions update, enable feature Collection Owner. This enables users to create collections as the collection owner.
How Has This Been Tested?
New functions added and tested.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist