-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for popular CRDs #2
Comments
Some brainstorming, given
Some options:
Any thoughts on a preference? (Let me know how I can help get Istio's CRDs in there!) |
I vote for |
Yes, that’s also my preference 👍 subdomains get complicated very easily |
I made some progress on this today. I decided to go with the subpath like It's still a bit buggy, but we'll get there :) For now I'm keeping the list of projects under https://github.com/aptakube/kubespec.dev/blob/main/src/lib/crds/projects.ts |
@goenning this is looking really awesome! Kubespec.dev is easily the best implementation I've seen of k8s spec documentation and the way you've implemented CRD pulling makes it easily extensible too! I'm looking at running a copy of this project internally to serve as user documentation, restricting it to just CRDs we have installed on our platform clusters to show our internal customers what things we support.
I had a try at adding some extra CRDs but one thing I got caught on is that some providers e.g. Argo Rollouts have versions that don't follow semver spec e.g. 'stable', so this logic might need to be relaxed when dealing with CRDs.
|
That’s an interesting use case, I think we could support that via environment variables where you can select which CRDs to show? And maybe another variable to select which Kubernetes version(s) as well
it seems like Argo has both semver + named tags, I think we could just ignore non-semver tags? There’s an example in that list on how to ignore tags |
Looks awesome! One possible suggestion for Istio is the versions are all identical in schema and will never not be identical. Might be a bit cleaner to not show the multiple copies in that regard? For a generic non-Istio specific case, I think you can say the same for any CRD that doesn't specify |
There is definitely not value in having multiple entries. There may be some value in showing the list of versions, so maybe something like you have as the alternative view above. I would think maybe even only on the detail view instead of the overview perhaps to reduce some noise, but not a big deal. All the same can apply to https://kubespec.dev/gateway-api as well btw |
Do you distinguish between description/comment changes and field changes? |
The changes we currently highlight are:
But I also want to support changes to type, enum, validation and other things |
Not sure how to do it though...
The text was updated successfully, but these errors were encountered: