Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Maui dependency #4

Open
prin53 opened this issue Jun 3, 2024 · 1 comment · May be fixed by #12
Open

Remove Maui dependency #4

prin53 opened this issue Jun 3, 2024 · 1 comment · May be fixed by #12

Comments

@prin53
Copy link

prin53 commented Jun 3, 2024

We have .NET iOS/Android project and not using Maui, so using the library end ups with:

Could not find Microsoft.Maui referenced by assembly Aptabase.Maui, Version=0.0.9.0, Culture=neutral, PublicKeyToken=null.

I am sure that reference is needed to extend the MauiAppBuilder, and can be safely removed in favour of compatibility.
@cristipufu
Copy link
Member

Hi @prin53,

This is a very good idea, we were planning on having a lighter nuget package w/o the Maui dependency, which could be used with WPF / WinUI as well.

Besides the MauiAppBuilder extension method, we need a way to detect the OS Name and Device Model

var platform = DeviceInfo.Current.Platform;
var deviceModel = DeviceInfo.Current.Model;

BrycensRanch added a commit to BrycensRanch/aptabase-dotnet that referenced this issue Dec 19, 2024
@BrycensRanch
feat: add Aptabase.Core
3955993 
Fixes aptabase#4

The GitHub repository should be renamed to aptabase-dotnet following the merge of this pull request. Maui should work... (I can't test that, I'm on Fedora Linux)
@BrycensRanch BrycensRanch linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Aptabase.Core BrycensRanch/aptabase-dotnet
2 participants
@cristipufu @prin53