Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apostrophes are not handled correctly in invalid card names #55

Open
KingSupernova31 opened this issue Jul 28, 2018 · 1 comment
Open

Apostrophes are not handled correctly in invalid card names #55

KingSupernova31 opened this issue Jul 28, 2018 · 1 comment

Comments

@KingSupernova31
Copy link

KingSupernova31 commented Jul 28, 2018 •
edited
Loading

If the user enters an unrecognized card name, any apostrophes will be rendered as their HTML code of "'". (The "single right quote" character that some sites use is rendered properly.)
@Nightfirecat
Copy link
Contributor

This line just needs to have its .replace(/'/g, '&#39;') removed. Thinking about it, it'd probably be safe to remove everything except the replacements for <, > and &... The replacements for ' and " may not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nightfirecat @KingSupernova31