Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Create contribution guide #21

Open
Nightfirecat opened this issue May 29, 2015 · 4 comments
Open

Suggestion: Create contribution guide #21

Nightfirecat opened this issue May 29, 2015 · 4 comments

Comments

@Nightfirecat
Copy link
Contributor

Most projects will include a CONTRIBUTING.md file (like the README) in the root directory of the project to help define certain style guidelines and principles that a project adheres to. This is an exmaple, which is used by the Cockatrice project. I noticed that the most recent commit made some changes to the code to start making a consistent style (tabs->spaces, apostrophe-surrounded strings, etc.), so I figured that now may be a good time to establish your preferred style so others can use it as well.

@Nightfirecat Nightfirecat changed the title Suggestion: Create contribution guide. Suggestion: Create contribution guide May 29, 2015
@april
Copy link
Owner

april commented Jun 6, 2015

That's not a bad idea. I'll copy up my eslint rules and link to the Google Javascript Style recommendations when I have a chance. :)

@april
Copy link
Owner

april commented Jun 7, 2018

I now have an .eslintrc, so hopefully I can start to enforce it with TravisCI soon.

@tooomm
Copy link

tooomm commented Jun 8, 2018

Cool, that's a great plan!
That would be a different "issue" though?

@april
Copy link
Owner

april commented Jun 8, 2018

That will be, but the .eslintrc file is good for contributing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants