Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - Verify Revision #1556

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[FEATURE] - Verify Revision #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d0be70
[FEATURE] - Verify Revision
gambol99 Nov 15, 2024
ffe0a86
chore: ammending the link to the policies
gambol99 Nov 15, 2024
89df146
fix: ignoring the linting errcheck error
gambol99 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/cmd/tnctl/create/revision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ func NewRevisionCommand(factory cmd.Factory) *cobra.Command {
flags.StringVarP(&o.File, "file", "f", "", "The path to save the revision to")
flags.StringVar(&o.Provider, "provider", "aws", "The name of the terranetes provider to use")

_ = c.MarkFlagRequired("file")

return c
}

Expand Down
11 changes: 8 additions & 3 deletions pkg/cmd/tnctl/verify/revision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ type RevisionCommand struct {
// EnableTerraformPlan indicates we should use a terraform plan to verify the security policy.
// Note, this does require credentials to be configured
EnableTerraformPlan bool
// ShowGuidelines indicates we should show the guidelines in the output
ShowGuidelines bool
// Contexts is a list of contexts from the cluster
Contexts *terraformv1alpha1.ContextList
// Policies is a list of policies from the cluster
Expand Down Expand Up @@ -129,6 +131,7 @@ func NewRevisionCommand(factory cmd.Factory) *cobra.Command {
flags.BoolVar(&o.EnableCluster, "use-cluster", true, "Indicates if we should retrieve configuration from the current kubeconfig")
flags.BoolVar(&o.EnableTerraformPlan, "use-terraform-plan", false, "Indicates if we should use a terraform plan to verify the security policy")
flags.BoolVar(&o.KeepTempDir, "keep-temp-dir", false, "Indicates if we should keep the temporary directory")
flags.BoolVar(&o.ShowGuidelines, "show-guidelines", true, "Indicates if we should show the guidelines in the output")
flags.StringVar(&o.CheckovImage, "checkov-image", "", "The docker image of checkov to use when validating the security policy")
flags.StringVar(&o.TerraformImage, "terraform-image", "", "The docker image of terraform to use when generating a plan")
flags.StringVarP(&o.Directory, "directory", "d", "", "Path to a directory to store temporary files")
Expand Down Expand Up @@ -629,7 +632,7 @@ func (o *RevisionCommand) checkSecurityPolicy(ctx context.Context) error {
failed := gjson.GetBytes(results, "results.failed_checks")
if failed.Exists() && failed.IsArray() {
if len(failed.Array()) > 0 {
v.Info("Check ID against documentation: https://docs.bridgecrew.io/docs")
v.Info("Checks: https://www.checkov.io/5.Policy%%20Index/all.html")
}

for _, check := range failed.Array() {
Expand All @@ -640,6 +643,9 @@ func (o *RevisionCommand) checkSecurityPolicy(ctx context.Context) error {
if check.Get("resource").String() != "" {
v.Additional("Resource: %v", check.Get("resource"))
}
if o.ShowGuidelines && check.Get("guideline").String() != "" {
v.Additional("Guideline: %v", check.Get("guideline"))
}
}
}

Expand Down Expand Up @@ -667,8 +673,7 @@ func (o *RevisionCommand) checkValueFromReferences(revision *terraformv1alpha1.R
}

for _, x := range revision.Spec.Configuration.ValueFrom {
switch {
case o.Contexts == nil:
if o.Contexts == nil {
v.Warning("Revision references a context: %q, key: %q, but none available to check against", *x.Context, x.Key)

continue
Expand Down