Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alz #2

Closed
wants to merge 9 commits into from
Closed

Feature/alz #2

wants to merge 9 commits into from

Conversation

earldata
Copy link
Contributor

@earldata earldata commented Sep 7, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📖 Terraform Documentation: failure

Pusher: @earldata, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/6572685351

variables.tf Outdated Show resolved Hide resolved
Repository = "Your Repository URL"
Provisioner = "Terraform"
}
user_assigned_identity = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/wayfinder/providers/Microsoft.ManagedIdentity/userAssignedIdentities/wayfinder-aks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there only a User Assigned Identity we need to create and the AKS module handles associating any required permissions to the identity, or are there any other setup prerequisites? Probably be good to add that in the readme (.terraform-docs.yml).

@earldata earldata closed this Oct 31, 2023
@earldata earldata deleted the feature/alz branch October 31, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants