Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to official external-dns chart and use Workload Identity. #15

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Switch to official external-dns chart and use Workload Identity. #15

merged 3 commits into from
Oct 25, 2023

Conversation

KashifSaadat
Copy link
Member

@KashifSaadat KashifSaadat commented Oct 24, 2023 •
edited
Loading

  • Updated to AKS v1.26. This needs a 2 stage upgrade for the control plane and node pools, hence the split to two Terraform variables.
  • Avoid using computed values in the count checks, as Terraform can't determine on a plan whether the resource needs to be created and so throws an error.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📖 Terraform Documentation: success

Pusher: @KashifSaadat, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/6638855631

mrsheepuk
mrsheepuk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@mrsheepuk mrsheepuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@KashifSaadat KashifSaadat merged commit 7faf55e into vnext Oct 25, 2023
7 checks passed
@KashifSaadat KashifSaadat deleted the external-dns-wi branch October 25, 2023 10:13
mrsheepuk pushed a commit that referenced this pull request Oct 25, 2023
@KashifSaadat @mrsheepuk
Switch to official external-dns chart and use Workload Identity. (#15)
167c762 
* Switch to official external-dns chart and use Workload Identity.

* Fixups

* Cloudaccess examples: Always set resource suffix, reorder vars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsheepuk mrsheepuk mrsheepuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KashifSaadat @mrsheepuk