Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: split building and deploying doc #563

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

skoh7645
Copy link
Collaborator

@skoh7645 skoh7645 commented Apr 7, 2020

Checklist

  • commit message follows commit guidelines.
  • website builds and runs in production - for information on how to test locally go here.

Description

Split up the "building and deploying" doc into " building", "deploying" and "appsody operator" docs. I tried to keep the content largely the same in this PR. Future PRs will be made to improve the actual content.

For easier reviewing:

  • "Building" doc is taken from the original "building and deploying" doc. I only added the first 2 paragraphs and the last line
  • "Deploying" doc is the original "building and deploying" doc with the "building" and "appsody operator" sections removed from it. I only made changes to the # Getting ready to deploy your Appsody project section, and the last sentence in the ### Deployment via the Appsody Operator section
  • "Appsody Operator" doc is directly taken from the original "building and deploying" doc with no additional changes

Related Issues

Related to #359

@helenmasters
Copy link
Contributor

You'll need to add redirects, changes to the sidebar yaml and any direct website refs also need updating...


The Appsody CLI downloads and runs a *development* Docker image of the target runtime during local development. This image differs slightly from the image that is used at deployment time, because it configures tools that are useful only during the development phase.

The Appsody CLI provides the [`appsody build`](/docs/cli-commands/#appsody-build) command to generate a *deployment* Docker image on your local Docker registry.
Copy link
Contributor

@helenmasters helenmasters Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should be the first sentence and the sentence/paragraph above should be a note/comment underneath, as it seems strange to talk about development first on a page about build.

It also feels like it should say something like...

"The Appsody CLI provides the appsody build command to generate a deployment Docker image on your local Docker registry. You can then manually deploy that image to your runtime platform of choice.".

That is it should cover what is appsody build and why would you use it. Then we should note something about it it being included in appsody deploy as for some users they won't want to use build directly.

"If you want to build and deploy a Docker image directly to a locally installed Kubernetes cluster that you are using for testing or staging you might prefer to use appsody deploy (link to command) as it has the build command built into it." not the right wording probably but you know what I mean...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to reword it taking this into account :)

Copy link
Contributor

@helenmasters helenmasters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in file

@skoh7645
Copy link
Collaborator Author

skoh7645 commented Apr 7, 2020

I have added one redirect which is the main one. I think we can add redirects for anchor links that we are aware have been used externally. However, we will probably have to accept some breakages as we can't redirect every anchor header. I've also updated the sidebar yaml and any direct website link references

@helenmasters
Copy link
Contributor

Sandy, I dreamt about the docs last night (sad I know!). Is there a link from the deploying doc to the operator docs as I didn't notice one yesterday? There should be something to show users that there is more information in Reference otherwise we can't expect users to find it.

@skoh7645
Copy link
Collaborator Author

skoh7645 commented Apr 8, 2020

@helenmasters haha sorry to hear about that. There is a link to the operator doc at the end of the ### Deployment via the Appsody Operator section

Copy link
Contributor

@neeraj-laad neeraj-laad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skoh7645 skoh7645 dismissed helenmasters’s stale review April 8, 2020 09:30

requested changes have been addressed

@skoh7645 skoh7645 merged commit 82f6a33 into appsody:master Apr 8, 2020
@skoh7645 skoh7645 deleted the splitbuildanddeploy branch April 8, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants