-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for unmaintained Elixir/Erlang versions #881
Labels
Comments
tombruijn
added a commit
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. See also #881 for dropping those older versions.
tombruijn
added a commit
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. See also #881 for dropping those older versions.
tombruijn
added a commit
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. See also #881 for dropping those older versions.
tombruijn
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. Related PR in appsignal-elixir repo: appsignal/appsignal-elixir#882 See also appsignal/appsignal-elixir#881 for dropping those older versions.
tombruijn
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. Related PR in appsignal-elixir repo: appsignal/appsignal-elixir#882 See also appsignal/appsignal-elixir#881 for dropping those older versions.
tombruijn
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. Related PR in appsignal-elixir repo: appsignal/appsignal-elixir#882 See also appsignal/appsignal-elixir#881 for dropping those older versions.
tombruijn
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this issue
Aug 28, 2023
Newer versions of Dialyxir use the [Kernel.then/2](https://hexdocs.pm/elixir/Kernel.html#then/2) syntax introduced in Elixir 1.12. Lock the package to 1.3, so we can run it on older versions while we still support them. Related PR in appsignal-elixir repo: appsignal/appsignal-elixir#882 See also appsignal/appsignal-elixir#881 for dropping those older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some Elixir and Erlang versions that we support are EOL. We should drop support for them at some point. Doing so would allow us to clean up lots of special casing for different versions, especially when declaring dependencies, using compile-time environment variables, or establishing SSL connections.
Dropping support should probably be done as a major version release, given that
appsignal-elixir-plug
andappsignal-elixir-phoenix
declare a dependency onappsignal >= 2.0.x
.Here are draft PRs that do the cleanup mentioned above:
We need to decide when we want to do this. It seems that other libraries bumped the minimum version to Elixir 1.11 or Elixir 1.12 alongside with releasing support for Elixir 1.15 (which we already support) so we wouldn't be alone in this:
The text was updated successfully, but these errors were encountered: